src: remove unused v8::TryCatch namespace#32729
Closed
juanarbol wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove unused v8::TryCatch namespace#32729juanarbol wants to merge 1 commit intonodejs:masterfrom
juanarbol wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
juanarbol
force-pushed
the
juanarbol/remove-unusedv8-namespace
branch
from
2f3c01e to
fc069a0
Compare
addaleax
approved these changes
Apr 9, 2020
Flarna
approved these changes
Apr 9, 2020
Collaborator
himself65
approved these changes
Apr 9, 2020
cjihrig
approved these changes
Apr 9, 2020
himself65
added
the
author ready
Collaborator
targos
approved these changes
Apr 9, 2020
Member
|
Would it be possible to have a lint rule for this? |
Member
I thought we had a tool for looking for unused Edit: https://github.com/nodejs/node/blob/master/tools/check-imports.py. If it isn't catching this I assume it's #29226. |
lpinca
approved these changes
Apr 9, 2020
Collaborator
Collaborator
Collaborator
Collaborator
himself65
pushed a commit
that referenced
this pull request
Apr 11, 2020
PR-URL: #32729 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 468d05a |
targos
pushed a commit
that referenced
this pull request
Apr 13, 2020
PR-URL: #32729 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
PR-URL: #32729 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32729 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes